mozilla / rkv

A simple, humane, typed key-value storage solution.
https://crates.io/crates/rkv
Apache License 2.0
310 stars 53 forks source link

Merge 'safe mode' to master, do a major version bump #178

Closed victorporof closed 4 years ago

victorporof commented 4 years ago

I think we're now ready for this.

ncloudioj commented 4 years ago

Go for it!

Let's also update the crate document to make consumers aware of this change.

victorporof commented 4 years ago

@ncloudioj What do you mean by "update the crate document"?

ncloudioj commented 4 years ago

oh, i mean this one https://docs.rs/rkv/0.10.2/rkv/

victorporof commented 4 years ago

oh, i mean this one https://docs.rs/rkv/0.10.2/rkv/

@ncloudioj Doesn't that happen automatically when pushing to crates.io?

victorporof commented 4 years ago

Oh I see what you mean, crate documentation in lib (and other files) is outdated.

rnewman commented 4 years ago

@victorporof is there something still outstanding before this can be rebased and merged? I want to know before I have to do a bunch of PRs twice, once for master that will go to crates.io, and once for safe-mode

victorporof commented 4 years ago

@rnewman The only thing remaining IIRC is to update the crate documentation. No other blockers, and I'm happy to get this landed.

rnewman commented 4 years ago

@victorporof when I check this out and build it locally, I get 47 build errors like this:

error[E0432]: unresolved import `super::DatabaseFlagsImpl`
  --> src/backend/impl_safe/database.rs:18:5
   |
18 | use super::DatabaseFlagsImpl;
   |     ^^^^^^^-----------------
   |     |      |
   |     |      help: a similar name exists in the module: `DatabaseImpl`
   |     no `DatabaseFlagsImpl` in `backend::impl_safe`

What's up?

victorporof commented 4 years ago

Sorry this slipped off my radar, will try to land asap.

victorporof commented 4 years ago

@rnewman This builds just fine for me locally on latest stable and nightly. I'm not sure what's up in your case, are you still running into this?