search

mozilla / rkv

A simple, humane, typed key-value storage solution.
https://crates.io/crates/rkv
Apache License 2.0
304 stars 52 forks source link

Put LMDB support behind a feature #223

Closed badboy closed 1 year ago

badboy commented 1 year ago

This would disable the LMDB backend by default. Note that for some time Glean will still enable that (bug 1772148), though disabling that in m-c (and on Android) might come sooner than on our iOS builds.

In the future then fully removing it is as easy as removing the gated code.

badboy commented 1 year ago

Quite a lot of compiler errors, do you think you can get some time to fix it? Otherwise I can take this.

"worked on my machine" -- hehe. Yes, I'll take a look.

badboy commented 1 year ago

All kinds of other weird errors now. I'll look into that tomorrow

badboy commented 1 year ago

Now this is starting to look better. But it required a couple of unrelated changes to get CI to work again, while avoiding a MSRV bump. I plan to do some cleanup (and really an MSRV bump) as a followup.