search

mozilla / rkv

A simple, humane, typed key-value storage solution.
https://crates.io/crates/rkv
Apache License 2.0
304 stars 52 forks source link

Introduce a recovery strategy as a replacement for set_discard_if_corrupted #235

Closed badboy closed 7 months ago

badboy commented 1 year ago

Fixes #234

This is a breaking change because of the now-changed public API

badboy commented 1 year ago

SIGABRTs for the mac tests. yey, gonna need to look into that.

badboy commented 1 year ago

SIGABRTs gone now, with latest Rust (1.68.2, released hours ago). I suspect some resource exhaustion, which happens to be gone now? 🤷

badboy commented 1 year ago

(the one remaining called out by github is on the push, not the pull request. #236 is taking care of not launching all those CI runs on push)

saschanaz commented 8 months ago

(Closing and reopening to retrigger the CI)

saschanaz commented 8 months ago

BTW, sorry for the huge delay, this just slipped. I hope there's a central Mozilla dashboard to manage both Phabricator and GitHub 😅

Or at least a separate GitHub dashboard for my paid job...

badboy commented 8 months ago

BTW, sorry for the huge delay, this just slipped. I hope there's a central Mozilla dashboard to manage both Phabricator and GitHub 😅

Or at least a separate GitHub dashboard for my paid job...

No worries. I guess no one ever really pushed for this anyway.

badboy commented 8 months ago

I addresses the first few things, but I need to think about the filename part a bit more.

saschanaz commented 7 months ago

Nice, r+ 👍 (I can't reapprove that I already did, apparently 😄)