search

mozilla / rust-android-gradle

Apache License 2.0
1.03k stars 67 forks source link

Always use the NDK version from `source.properties`. #145

Closed ncalexan closed 2 months ago

ncalexan commented 2 months ago

Previously, RustAndroidPlugin would read the NDK version from source.properties in the NDK path, while CargoBuildTask would try to infer the NDK version from the pathname.

Inferring the NDK version from the pathname would fail if the pathname didn't contain the version (e.g., Mach currently installs the NDK used to build Firefox for Android into ~/.mozbuild/android-ndk-r26c), causing Toolchain to return the wrong path to ar for new NDK versions.

ncalexan commented 2 months ago

@linabutler I fixed the tests and rebased this PR against the fixes. If it's green, I think it probably makes sense to land it, we'll find out tomorrow.

linabutler commented 2 months ago

Thank you so much for fixing up the tests, @ncalexan; it's nice to see another green run! 🏆

I know you've been putting out other fires this week, so there's no hurry to get this landed. Whenever you have time, though, would you mind cutting a release with these changes, please?

I don't know much at all about how dependencies work in the JVM world (artifacts? repositories? tags? tooling?), and it would be great to see how you do it, so that I and other Application Services folks know how to do it next time 😊