search

mozilla / rust-android-gradle

Apache License 2.0
1.03k stars 67 forks source link

Sample App Incorrect or Out of Date #25

Closed drkstr101 closed 3 years ago

drkstr101 commented 4 years ago

https://github.com/mozilla/rust-android-gradle/blob/16a12c2dd20fb9a7bc35cf6c5f813f65b49d775d/samples/app/build.gradle#L39

Hello,

I believe the referenced line should read libname = "rust". According to the README, targetIncludes defaults to ["lib${libname}.so", "lib${libname}.dylib", "{$libname}.dll"], making the lib prefix reduntant.

Until I made this change locally, the sample app was not correctly linking librust.so in the apk, leading to a bit of confusion getting started. Otherwise works like a charm.

Cheers, and thanks for your time!

ncalexan commented 4 years ago

Thanks for the report, and sorry for the slow reply! I'm largely not touching this at this time but I'd gladly take a PR to apply.

drkstr101 commented 4 years ago

No problem, thanks for the reply! PR sent. Cheers!

ncalexan commented 3 years ago

Better late than never, right? :)