search

mozilla / rust-android-gradle

Apache License 2.0
1.03k stars 67 forks source link

Added missing env var CXX_<triple> #26

Closed katyo closed 4 years ago

katyo commented 4 years ago

This is important also specify appropriate C++ compiler for building bundled C++ libraries and/or bindings.

For example cmake fails compile rust bindings for liboboe without it.

thomcc commented 4 years ago

Seems reasonable to me. I'll land this. I'd also like to get #21 in this release (which I though I already landed 😬) and will cut it after I do some smoke-testing.

(And I wonder if the ar stuff even works on Windows, since we don't append .cmd.)

.cmd is in the windows PATHEXT environment var by default so it's not required.