mozilla / rust-android-gradle

Apache License 2.0
1.03k stars 67 forks source link

The check for existing standalone toolchains is not resilient to missing files #57

Open dcsommer opened 3 years ago

dcsommer commented 3 years ago

GenerateToolchainsTask.kt checks if the standalone toolchain exists before regenerating it. If some process reaps files from java.io.tmpdir but leaves the top-level directory for that standalone toolchain in place, builds may fail in unpredictable ways. Running make_standalone_toolchain.py is quite fast, so we might consider removing the "already exists" check. --force also takes care of overriding contents properly, so the change is fairly straightforward: just remove the check.