search

mozilla / rust-android-gradle

Apache License 2.0
1.08k stars 70 forks source link

[question] rustup automatically ? #71

Open paulvi opened 3 years ago

paulvi commented 3 years ago

If this plugin (or other plugin) can help to setup Rust environment automatically, so that project with Rust part could be built on any CI server (without preparations), just gradle build

ncalexan commented 3 years ago

Hello @paulvi! I have no strong opinions about this, but I do I have a mild preference to not make this plugin the kitchen sink for everything Rust related. It's not clear to me that there's an advantage to having this plugin invoke rustup .... I suppose this plugin knows the set of target architectures in play, so it can invoke rustup target add ... correctly? That might be compelling.

Is it better to have first-class support for this, or can users just add a pre-action or a prerequisite task that does this work for each cargoBuild${architecture} task?

While we're here, are there common CI systems that don't come with preconfigured toolchains in their images? I know Github Actions, for example, have all of this stuff baked in, so one shouldn't need to rustup anything. But presumably other providers have different baselines. What provider are you trying to work with? Is it possible that you should just invoke rustup manually before invoking Gradle?

paulvi commented 3 years ago

well, I think it should not fail if rust is not installed. And should installed default target fur current platform.

My concerns were Security, as that would required downloading something from Internet from 3rd party service ( even seemingly trustable )

I could not find anything standard from gradle toolchains...