search

mozilla / rust-android-gradle

Apache License 2.0
1.03k stars 67 forks source link

Add aarch64 target for darwin desktops #78

Closed skhamis closed 2 years ago

skhamis commented 2 years ago

fixes #77

Turned out to be a very small patch! Tested with both x86_64 and arm64 JDKs and both seem to compile nicely (the a-s issue mentioned in https://github.com/mozilla/rust-android-gradle/issues/77) . The only issue is I don't necessarily know the best way to handle the deprecation of darwin to officially split darwin to use the {-x86_64, -aarch64}. Throwing this up for early visibility....

skhamis commented 2 years ago

@ncalexan What do you think of going the darwin + darwin-{x86_64, aarch64} vs just removing the darwin target (breaking change) and only have the darwin with the modifiers? Curious your thoughts!

skhamis commented 2 years ago

@ncalexan Thanks for the review! I have applied all requested nits/changes and rebased ontop of https://github.com/mozilla/rust-android-gradle/pull/81 for those CI runs. I also squashed and bumped the plugin version -- let me know if I missed anything! Should look good once the CIs pass!

ncalexan commented 2 years ago

I landed this manually onto master: c4bf58464af845fb97bbf7b15a5f4603f3af9dca.

Sorry for the unusual landing; I had some CI testing to work through. Thanks for pushing this forward, @skhamis!

ncalexan commented 2 years ago

Oh -- I cut v0.9.1 with this change as well. Please test and make sure it works for y'all!