mozilla / rust-code-analysis

Library to analyze and collect metrics on source code
https://mozilla.github.io/rust-code-analysis/
262 stars 46 forks source link

Make some traits private #1042

Closed Luni-4 closed 1 year ago

Luni-4 commented 1 year ago

This PR makes CodeMetricsT and TSLanguage traits private, since they are only used inside the lib crate to simplify language constructions, thus they should not be used outside the main lib

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (9b7ead6) 74.19% compared to head (20531a3) 74.19%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1042 +/- ## ======================================= Coverage 74.19% 74.19% ======================================= Files 64 64 Lines 15923 15923 ======================================= Hits 11814 11814 Misses 4109 4109 ``` | [Impacted Files](https://codecov.io/gh/mozilla/rust-code-analysis/pull/1042?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | Coverage Δ | | |---|---|---| | [src/macros.rs](https://codecov.io/gh/mozilla/rust-code-analysis/pull/1042?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla#diff-c3JjL21hY3Jvcy5ycw==) | `65.21% <ø> (ø)` | | | [src/parser.rs](https://codecov.io/gh/mozilla/rust-code-analysis/pull/1042?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla#diff-c3JjL3BhcnNlci5ycw==) | `35.21% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.