search

mozilla / rust-code-analysis

Library to analyze and collect metrics on source code
https://mozilla.github.io/rust-code-analysis/
276 stars 49 forks source link

Modify tests for more deterministic behavior #1081

Closed michaelvanstraten closed 8 months ago

Luni-4 commented 8 months ago

@michaelvanstraten

Now that #1078 has been merged, we can fix CI using this PR. Let's use yaml comparisons and not json due to the advice written here. We can also integrate the missing features present in https://github.com/mozilla/rust-code-analysis/pull/1080

We need to update the snapshots accordingly in the rust-code-analysis-output repository

michaelvanstraten commented 8 months ago

Let's use yaml comparisons

Already implemented, for the same reason.

We can also integrate the missing features present in #1080

Do you mean the switch to std::collections::Hashmap, the sorting of maps or both?

Luni-4 commented 8 months ago

We can just sort out the maps in this PR, thanks for the catch!

michaelvanstraten commented 8 months ago

@Luni-4, tests pass except for the three sitter checks, can you check it out?