search

mozilla / rust-code-analysis

Library to analyze and collect metrics on source code
https://mozilla.github.io/rust-code-analysis/
276 stars 49 forks source link

Update grammars #1086

Closed alexle0nte closed 1 month ago

alexle0nte commented 4 months ago

This PR:

aytey commented 2 months ago

@alexle0nte: is there a chance you could undraft this? It seems your PR is the only way for me to build rust-code-analysis, so it would be great if these changes could be upstreamed.

alexle0nte commented 2 months ago

@alexle0nte: is there a chance you could undraft this? It seems your PR is the only way for me to build rust-code-analysis, so it would be great if these changes could be upstreamed.

I will start working on this PR again in the coming days. I’ve noticed that, although the tests pass, there are errors in the computation of some metrics for certain languages due to the grammar version update.

marco-c commented 2 months ago

@alexle0nte: is there a chance you could undraft this? It seems your PR is the only way for me to build rust-code-analysis, so it would be great if these changes could be upstreamed.

I will start working on this PR again in the coming days. I’ve noticed that, although the tests pass, there are errors in the computation of some metrics for certain languages due to the grammar version update.

Ciao Alex. If there are more improvements than regressions, we could consider landing the changes anyway and filing follow-up issues for the regressions.

alexle0nte commented 2 months ago

Ciao @marco-c! Ok, so can we merge the PR even if not all tests pass, and then fix them in a new PR?

marco-c commented 2 months ago

Yes I think so, after all tests are failing on master anyway.

marco-c commented 1 month ago

@alexle0nte let me know when you're ready

alexle0nte commented 1 month ago

@alexle0nte let me know when you're ready

It's ready for review

marco-c commented 1 month ago

I've filed #1091 for the follow-up work.