replace failure with thiserror and backtrace

mozilla / rust-ece

Encrypted Content-Encoding for HTTP (RFC 8188) Rust implementation

Mozilla Public License 2.0

25 stars 11 forks source link

replace failure with thiserror and backtrace #40

Closed tarikeshaq closed 4 years ago

tarikeshaq commented 4 years ago

Hello team! We are getting rid of the failure crate in application-services since failure is deprecated, and moving our components to use thiserror instead.

The fxa-client component consumes this crate, so this pull request replaces failure with thiserror.

Ran cargo test, cargo fmt and cargo clippy before making this pull-request

Let me know what you think!

eoger commented 4 years ago

Huh I wanted to get the answer to https://github.com/mozilla/application-services/pull/3132/files#r428094903 before merging, but that's fine we'll do another PR if needed.

tarikeshaq commented 4 years ago

Opened #42 with a couple more changes that should have been a part of this, I could add any other needed changes there @eoger