search

mozilla / scanjs

[DEPRECATED] Static analysis tool for javascript code.
Other
429 stars 38 forks source link

Bug: acorn.js does not handle parse error smoothly #103

Closed pwnetrationguru closed 10 years ago

pwnetrationguru commented 10 years ago

If I select a bunch of files to scan, and one of them has a syntax error (according to accorn.js, as the syntax errors seem to be legit JS syntax just not for accorn.js but I need to verify this), then I see no indication in the interface.

The user should get a warning, indicating which file has syntax error.

The scan should continue onto other files, not abort entire scan if one file has syntax error.

pauljt commented 10 years ago

Thats not acorn’s fault - we need to handle this in scan.js.

On 2 Apr 2014, at 6:21 am, Rob Fletcher notifications@github.com wrote:

If I select a bunch of files to scan, and one of them has a syntax error (according to accorn.js, as the syntax errors seem to be legit JS syntax just not for accorn.js but I need to verify this), then I see no indication in the interface.

The user should get a warning, indicating which file has syntax error.

The scan should continue onto other files, not abort entire scan if one file has syntax error.

— Reply to this email directly or view it on GitHub.

mozfreddyb commented 10 years ago

yeah see #53

pwnetrationguru commented 10 years ago

ahh, i see. I've marked #53 as milestone 1.0 so we can have that fixed in our 1.0 version.