search

mozilla / scanjs

[DEPRECATED] Static analysis tool for javascript code.
Other
428 stars 39 forks source link

results display broken? #108

Closed mozfreddyb closed 10 years ago

mozfreddyb commented 10 years ago

See http://imgur.com/aWfgvBr

I think it's somewhere in line 111 and following, we have to <div>s with the id results-wrapper. that can't be right

pwnetrationguru commented 10 years ago

So did you actually run that scan?

Usually, that div is replaced one you actually click scan. If there are no results found, I think that div stays the same which definitely isn't ideal.

mozfreddyb commented 10 years ago

I did. I get this on master but not in gh-pages. If you don't know what caused it I will start bisecting...

mozfreddyb commented 10 years ago

I actually did not... I now see what caused the confusion: I didn't understand the filter function yet - sorry ;-) But we should probably hide the Results/Filter list headings if there is nothing to show underneath

pwnetrationguru commented 10 years ago

Yah, we also still need the throbber! :)

I'll see if I can get something in today as I have a little extra time

mozfreddyb commented 10 years ago

Nah, I'll do the throbbler together with #53, I already have a working prototyle

pwnetrationguru commented 10 years ago

Niice! sg