search

mozilla / scanjs

[DEPRECATED] Static analysis tool for javascript code.
Other
428 stars 39 forks source link

Ugraded from CodeMirror version 3.22 to 4.0 #116

Closed vivekkiran closed 10 years ago

mozfreddyb commented 10 years ago

Thanks for the pull request. Have you tried this works? We have no tests for the UI, so you'd have to play with it manually. There's also tests/ for some basic JS testing, which you should run.

(This applies to #117 too)

pwnetrationguru commented 10 years ago

These are unneeded updates, and I don't think the right way to contribute to the project. I nominate we close these PRs without merging.

pwnetrationguru commented 10 years ago

I've seen no comments regarding not closing, so I am closing and we can re-open if people feel strongly about it.