mozilla / scanjs

[DEPRECATED] Static analysis tool for javascript code.
Other
428 stars 39 forks source link

Stackato manifest #120

Closed mozfreddyb closed 10 years ago

mozfreddyb commented 10 years ago

With this commits, we can easily host scanjs on a stackato instance (which Mozilla, incidentically has). An important change is that server.js would only host the client/ if you want the URL to be half-way decent i.e., https://scanjs.paas.allizom.org/

This also fixes #24. An additional task would be to point our README to this other URL and forward the github pages. The new hosting environment has https :lock: ;))

What do you think? :)

mozfreddyb commented 10 years ago

I guess we could decide not to take this and I'll keep the stackato.yml file around locally. The changes to server.js are still useful but I can split this commit up.

pauljt commented 10 years ago

Not a bad idea. Is there some scripted way to publish updates? We want that I think - otherwise its just too easy to update the gh-pages to make it worth the switch imho.

mozfreddyb commented 10 years ago

Well, updating stackato requires manual action :/ But it's as easy as ./stackato update. I'm trying to find out if I can convince it to do git pull automatically

mozfreddyb commented 10 years ago

err, url is https://scanjs.paas.allizom.org/client/ :)

pwnetrationguru commented 10 years ago

An important change is that server.js would only host the client/ if you want the URL to be half-way decent i.e., https://scanjs.paas.allizom.org/

So you're saying tests would have to be a separate server.js file that we run?

pwnetrationguru commented 10 years ago

An important change is that server.js would only host the client/ if you want the URL to be half-way decent i.e., https://scanjs.paas.allizom.org/

So I think I mis-understood this comment since https://scanjs.paas.allizom.org/tests/ still works. Can you explain a little more what you mean?

pauljt commented 10 years ago

Please focus on MVP

On 17 Apr 2014, at 5:46 am, Rob Fletcher notifications@github.com wrote:

An important change is that server.js would only host the client/ if you want the URL to be half-way decent i.e., https://scanjs.paas.allizom.org/

So I think I mis-understood this comment since https://scanjs.paas.allizom.org/tests/ still works. Can you explain a little more what you mean?

— Reply to this email directly or view it on GitHub.

pwnetrationguru commented 10 years ago

@pauljt, should we close this until a later date or should we attempt to review the PR and get it merged?

pauljt commented 10 years ago

Looks fine to me to merge