search

mozilla / scanjs

[DEPRECATED] Static analysis tool for javascript code.
Other
429 stars 39 forks source link

[bug] - master is broken, rule.js line 28 ScanJS doesn't exist #126

Closed pwnetrationguru closed 10 years ago

pwnetrationguru commented 10 years ago

I get the following error on :master in both FF and Chrome

ReferenceError: ScanJS is not defined
    at new RuleListCtrl (http://127.0.0.1:4000/client/js/rules.js:28:50)
    at d (http://127.0.0.1:4000/client/js/lib/angular-1.2.13.min.js:30:452)
    at Object.instantiate (http://127.0.0.1:4000/client/js/lib/angular-1.2.13.min.js:31:80)
    at http://127.0.0.1:4000/client/js/lib/angular-1.2.13.min.js:62:417
    at http://127.0.0.1:4000/client/js/lib/angular-1.2.13.min.js:49:66
    at r (http://127.0.0.1:4000/client/js/lib/angular-1.2.13.min.js:7:386)
    at I (http://127.0.0.1:4000/client/js/lib/angular-1.2.13.min.js:48:436)
    at h (http://127.0.0.1:4000/client/js/lib/angular-1.2.13.min.js:42:437)
    at h (http://127.0.0.1:4000/client/js/lib/angular-1.2.13.min.js:42:454)
pwnetrationguru commented 10 years ago

Hmmm, so I might be doing something wrong, but :master seems to still have the errors :newscanner did. Namely, I get the above error about ScanJS in rules.js and the Experiment tab still doesn't work at all for me. I've tried to verify that I'm not newbing things up, but can @pauljt and @mozfreddyb let me know if you guys are getting the same results?

Thanks!

pauljt commented 10 years ago

Hmm rules.js shouldn’t be used any more - AcornWalker uses rules.json instead. Ill have a look.

On 19 Apr 2014, at 7:15 am, Rob Fletcher notifications@github.com wrote:

Hmmm, so I might be doing something wrong, but :master seems to still have the errors :newscanner did. Namely, I get the above error about ScanJS in rules.js and the Experiment tab still doesn't work at all for me. I've tried to verify that I'm not newbing things up, but can @pauljt and @mozfreddyb let me know if you guys are getting the same results?

Thanks!

— Reply to this email directly or view it on GitHub.

pauljt commented 10 years ago

I just tested again, including pulling a fresh repo. Works fine for me. Note i added js-beautify to the scanner.js so that snippets work. So if running that you may need to do npm install first. But that doesn't sound like your error above...

pwnetrationguru commented 10 years ago

Huh, interesting, but that's kinda what I figured (that it was something on my end). I'll verify my setup and follow up for sure!

Thanks for checking :boom:

mozfreddyb commented 10 years ago

Paul said

Hmm rules.js shouldn’t be used any more - AcornWalker uses rules.json instead. Ill have a look.

Yeah I removed it completely, maybe a caching issue?!