mozilla / scanjs

[DEPRECATED] Static analysis tool for javascript code.
Other
429 stars 39 forks source link

Fix Throbber #128

Closed pwnetrationguru closed 10 years ago

pwnetrationguru commented 10 years ago

This PR makes our throbber animated, using CSS3 and FontAwesome. We had a throbber of sorts for when ScanJS was running, but I've also added a throbber for when we are uploading files.

Things to note:

mozfreddyb commented 10 years ago

I don't like that we have to include a library just to get an animated throbber :( Can't we rather figure out how to make GIFs work instead instead of going down the road of adding a library for every problem we can't fix properly?

pwnetrationguru commented 10 years ago

This is the correct solution the problem, besides the fact FontAwesome gives us access to a lot of other things we can use in the future.

I asked about adding a GIF, and nobody wanted to do it. So instead, I fixed the problem correctly. BTW, I tried a GIF and it looked like crap.

pwnetrationguru commented 10 years ago

fwiw, FontAwesome will give us access to all of these icons: http://fortawesome.github.io/Font-Awesome/icons/

pwnetrationguru commented 10 years ago

All that being said, I do agree that we shouldn't just add libraries to solve problems we could easily solve in a different fashion :smile:

pauljt commented 10 years ago

I'm not thrilled about adding a library either, but it works, looks nice and the code looks fine to me. So I am merging so we can focus on more important issues.