search

mozilla / scanjs

[DEPRECATED] Static analysis tool for javascript code.
Other
429 stars 39 forks source link

New rules for APIs #136

Closed mozfreddyb closed 10 years ago

mozfreddyb commented 10 years ago

This reduces test failures in moz.js - Some tests are not really doing what the rules suggest, and I'd prefer solving this somewhere else than making the tests say what the rules do ;) e.g.

"window.navigator.mozWifiManager" should be caught by the navigator.mozWifiManager rule. But if I rewrite the test to $.navigator.mozWifimanager` it stops finding the case without window before it...

mozfreddyb commented 10 years ago

I regrouped audio permissions and removed mozSms in the latest commit

pauljt commented 10 years ago

Looks good to me, merged.