Allow reviewer to sort results (e.g by rule, as well as by file etc)

mozilla / scanjs

[DEPRECATED] Static analysis tool for javascript code.

Other

428 stars 38 forks source link

Allow reviewer to sort results (e.g by rule, as well as by file etc) #33

Closed pauljt closed 10 years ago

pauljt commented 10 years ago

Currently results are printed by file, which is pretty unhelpful if you are actually trying to do a review. It would be better to sort by issue, or even better allow the user to sort the results.

pwnetrationguru commented 10 years ago

Totally agree, I had this feeling using the interface the other day.

Would be nice to say 'show me innerHTML violations' and have it filter on that. I think some of the bootstrap frameworks come with handy search tools that look for text in the page so maybe we can utilize that. If that's the case, might even be possible for 0.1! :)

mozfreddyb commented 10 years ago

Yes, I agree as well. I discussed with paul that we want the results format that scanjs emits to be flatter and it shouldnt include the full rule details either. This will help immensely with sorting as well.

But it'll require changing a lot of bits :)

pauljt commented 10 years ago

This is now fixed as part of #59