[testing][false positive] - variable named same as object

[pwnetrationguru]

A lot of our rules flag variables named the same as the object as dangerous, when the shouldn't.

Currently, we have the following failing test cases:

     CustomEvent -> good.CustomEvent = "CustomEvent";
     addEventListener -> var addEventListener = "variable with name";
     addIdleObserver -> addIdleObserver = "static string";
     addIdleObserver -> something.addIdleObserver = "static string";
     escapeHTML -> var escapeHTML = "just a string";
     localStorage -> var localStorage = "asdf";
     message -> var message = "static string";
     MozActivity -> var MozActivity = "static MozActivity";
     MozChromeEvent -> var mozChromeEvent = "string mozChromeEvent";
     mozPermissionSettings -> var mozPermissionSettings = "just a string, not mozPermissionSettings";
     mozPower ->  var mozPower = "just a string, window.navigator.mozPower;";
     mozSettings -> var mozSettings = "window.navigator.mozSettings;";
     mozSms -> var mozSms = "window.navigator.mozSms;";
     somethingNotNavigator.mozWifiManager;

The following rules need be updated:

• CustomEvent
• addEventListener
• addIdleObserver
• escapeHTML
• localStorage
• message
• MozActivity
• MozChromeEvent
• mozPermissionSettings
• mozPower
• mozSettings
• mozSms
• mozWifiManager

[mozfreddyb]

this appears to be resolved