[testing][false positive] - data rule

[pwnetrationguru]

Currently, the rule flags the following safe input:

form.data = "mystring";

It should ignore this case, as we do not care about assignments to data. We care about using data, which could be untrusted, in unsafe ways.

[zombie]

i tested this, and it doesn't match any rule for me. what rule is it supposed to match (or not, as the case may be?)

[pauljt]

Im closing this as invalid as its too generic - I think what rob meant here was that we should match something like $_any.data. But that I think that is too generic to be useful in the default ruleset - people can always add this rule if they feel its helpful

[zombie]

i don't think this is right. he marked it as [false positive], and says the rule flags the input, not that it should flag it..

[pauljt]

We used to have a rule which matched .data. I removed it for the above reasons.

[zombie]

oh, ok, that makes a bit more sense..

[pauljt]

Yes sorry - there is a lot of cruft in these issues. You on mozilla irc? Come find me (pauljt in #security) and say hello!