Closed AJIOB closed 9 months ago
Attention: 38 lines
in your changes are missing coverage. Please review.
Comparison is base (
ffe3070
) 30.77% compared to head (2131617
) 30.70%.
Files | Patch % | Lines |
---|---|---|
src/config.rs | 15.62% | 18 Missing and 9 partials :warning: |
src/cache/cache.rs | 0.00% | 6 Missing :warning: |
src/cache/memcached.rs | 0.00% | 3 Missing :warning: |
src/cache/redis.rs | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
if i understand correctly this PR, it isn't going to change the behavior of existing configurations, right?
@sylvestre, yes, you are right.
I am not changed the current configuration API. Just documenting, unifying & extending it.
@Xuanwo, hello.
What I need to do for merging this PR?
Do we have some problems with this changes? Or I need to split it to few ones?
Those changes LGTM! cc @sylvestre do you want to take another look?
thanks!