Closed drahnr closed 8 months ago
It would be nice to update the commit to explicit why we are doing it
It would be nice to update the commit to explicit why we are doing it
The commit or the PR desc? Squash merge 'd be fine by me.
The commit please
Is the above sufficient @sylvestre ? I'd still be in favor of squash this PR, left the two commits separate for no particular reason other than authorship
Attention: 127 lines
in your changes are missing coverage. Please review.
Comparison is base (
ffe3070
) 30.77% compared to head (cbe79c9
) 32.17%. Report is 19 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
src/compiler/compiler.rs | 31.69% | 17 Missing and 108 partials :warning: |
src/test/tests.rs | 33.33% | 0 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The coverage report is obsolete, it actually improved marginally.
CC @sylvestre anything missing/insufficient, otherwise I'd merge with rebase?
If we are not sure it's rustc like and we check -vV output to accept valid rustc drivers. Simplifies #1897 .
Fixes #861