mozilla / sccache

Sccache is a ccache-like tool. It is used as a compiler wrapper and avoids compilation when possible. Sccache has the capability to utilize caching in remote storage environments, including various cloud storage options, or alternatively, in local storage.
Apache License 2.0
5.85k stars 552 forks source link

rustc driver detection - includes #1897 #2085

Closed drahnr closed 8 months ago

drahnr commented 9 months ago

If we are not sure it's rustc like and we check -vV output to accept valid rustc drivers. Simplifies #1897 .

Fixes #861

sylvestre commented 9 months ago

It would be nice to update the commit to explicit why we are doing it

drahnr commented 8 months ago

It would be nice to update the commit to explicit why we are doing it

The commit or the PR desc? Squash merge 'd be fine by me.

sylvestre commented 8 months ago

The commit please

drahnr commented 8 months ago

Is the above sufficient @sylvestre ? I'd still be in favor of squash this PR, left the two commits separate for no particular reason other than authorship

codecov-commenter commented 8 months ago

Codecov Report

Attention: 127 lines in your changes are missing coverage. Please review.

Comparison is base (ffe3070) 30.77% compared to head (cbe79c9) 32.17%. Report is 19 commits behind head on main.

Files Patch % Lines
src/compiler/compiler.rs 31.69% 17 Missing and 108 partials :warning:
src/test/tests.rs 33.33% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2085 +/- ## ========================================== + Coverage 30.77% 32.17% +1.40% ========================================== Files 52 53 +1 Lines 19913 20721 +808 Branches 9630 10296 +666 ========================================== + Hits 6129 6668 +539 + Misses 7959 7877 -82 - Partials 5825 6176 +351 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

drahnr commented 8 months ago

The coverage report is obsolete, it actually improved marginally.

CC @sylvestre anything missing/insufficient, otherwise I'd merge with rebase?