search

mozilla / sccache

Sccache is a ccache-like tool. It is used as a compiler wrapper and avoids compilation when possible. Sccache has the capability to utilize caching in remote storage environments, including various cloud storage options, or alternatively, in local storage.
Apache License 2.0
5.85k stars 552 forks source link

feat: Add Memcached authentication #2117

Closed AJIOB closed 8 months ago

AJIOB commented 8 months ago

~Must be merged only after #2114 and #2116, because this branch contains changes from both PRs.~

codecov-commenter commented 8 months ago

Codecov Report

Attention: Patch coverage is 5.71429% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 30.73%. Comparing base (0cc0c62) to head (b5d13f2). Report is 7 commits behind head on main.

Files Patch % Lines
src/config.rs 9.52% 10 Missing and 9 partials :warning:
src/cache/cache.rs 0.00% 9 Missing :warning:
src/cache/memcached.rs 0.00% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2117 +/- ## ========================================== - Coverage 30.91% 30.73% -0.18% ========================================== Files 53 53 Lines 20112 20184 +72 Branches 9755 9805 +50 ========================================== - Hits 6217 6204 -13 - Misses 7922 7979 +57 - Partials 5973 6001 +28 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AJIOB commented 8 months ago

@sylvestre & @Xuanwo, recheck it, please.

I think it is ready to be merged.