search

mozilla / sccache

Sccache is a ccache-like tool. It is used as a compiler wrapper and avoids compilation when possible. Sccache has the capability to utilize caching in remote storage environments, including various cloud storage options, or alternatively, in local storage.
Apache License 2.0
5.85k stars 552 forks source link

Bump zip from 0.6.6 to 2.1.3 #2227

Open glandium opened 4 months ago

glandium commented 4 months ago

This, unfortunately, comes with a massive performance regression: 25% ! So, PLEASE DO NOT MERGE.

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.20%. Comparing base (0cc0c62) to head (e544cad). Report is 64 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2227 +/- ## =========================================== + Coverage 30.91% 41.20% +10.29% =========================================== Files 53 53 Lines 20112 20472 +360 Branches 9755 9680 -75 =========================================== + Hits 6217 8436 +2219 - Misses 7922 8048 +126 + Partials 5973 3988 -1985 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Xuanwo commented 3 weeks ago

This, unfortunately, comes with a massive performance regression: 25% ! So, PLEASE DO NOT MERGE.

Do we need to report to the upstream?

sylvestre commented 3 weeks ago

it has been, see https://github.com/zip-rs/zip2/issues/231

sylvestre commented 3 weeks ago

and https://github.com/zip-rs/zip2/pull/247 for the potential fix