search

mozilla / sccache

Sccache is a ccache-like tool. It is used as a compiler wrapper and avoids compilation when possible. Sccache has the capability to utilize caching in remote storage environments, including various cloud storage options, or alternatively, in local storage.
Apache License 2.0
5.85k stars 552 forks source link

Pass through `--remap-path-prefix` argument. #2270

Open ColinFinck opened 1 month ago

ColinFinck commented 1 month ago

I don't see what's special about the --remap-path-prefix argument that it was marked as TooHard and not just passed through. I'm changing it to PassThrough here. This change has worked in a local test.

Please put my PR under scrutiny. This argument has been unsupported by sccache for a long time and it feels too simple to just change it to PassThrough.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.71%. Comparing base (0cc0c62) to head (9aebab5). Report is 81 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2270 +/- ## ========================================== + Coverage 30.91% 40.71% +9.80% ========================================== Files 53 54 +1 Lines 20112 20747 +635 Branches 9755 9642 -113 ========================================== + Hits 6217 8448 +2231 - Misses 7922 8152 +230 + Partials 5973 4147 -1826 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.