Closed pmclanahan closed 11 years ago
I skimmed the changes and had a few totally uninteresting comments. Some of the changes are hard to grok just by skimming. It'd help to have more docstrings to aid that. I definitely didn't see anything obviously wrong with what I skimmed other than that PRODUCT_CACHE isn't threadsafe, but I didn't do a deep dive to see how that's used.
Hope that helped!
Apologies for this being so huge. This should represent a huge improvement for scrumbugs. We'll need to get our email address added as a "universal follower" in BMO to take full advantage.