mozilla / seasponge

:pineapple: SeaSponge is an accessible threat modelling tool from Mozilla
http://mozilla.github.io/seasponge/
Mozilla Public License 2.0
278 stars 64 forks source link

Remove the "Made with <3 footer" #25

Closed MatKallada closed 10 years ago

MatKallada commented 10 years ago

Regarding the "Made with <3 by the Mozilla SeaSponge team" footer on the splash page of the application.

Although it is cute for smaller applications, hackathon ideas, companies, it should be avoided for this project.

Here are reasons that we shouldn't include it:

Although I mentioned it before in #24 , @Glavin001 said that we should:

Although it is a very small fix, this change will set the stage for the rest of the design choices for the application; we are aiming for a professionally-polished software (both from a software developer and product developer's perspective). Again, it is a small fix, however I really don't think discussing it further is a waste of time.

Glavin001 commented 10 years ago

Thanks for putting this into an issue so we can discuss :+1:.

MatKallada commented 10 years ago

@Glavin001 Could you elaborate why you think that this issue a waste of time to talk-about? There are valid reasons for removing the footer (or at least changing it with something meaningful).

Glavin001 commented 10 years ago

Talking about it is a waste of time

To reiterate and clarify what I had said in our Facebook discussion:

We had put in our opinions and the resulting vote was to keep it. ...further discussion on something that has already been settled and agreed upon I see as a waste. If everyone wishes to revisit the issue, then we can.

Glavin001 commented 10 years ago

This has been removed in commit https://github.com/mozilla/seasponge/commit/6c9b6443cfe1a96775e2302d5311bdfd8138b9b5 and will be merged along with Pull Request https://github.com/mozilla/seasponge/pull/24

MatKallada commented 10 years ago

@Glavin001 Thanks, but that is not an argumentative point. Do you have any actual design arguments for keeping this?

Lastly, I don't think you should not brush-off ideas down based on arbitrary voting schemes.

Edit:

I just seen that you removed it for some reason, but I still want to hear your points for keeping this.

Glavin001 commented 10 years ago

Our design arguments were simply opinions, similar to your own thoughts about keeping it such as "distraction to the user" and "childish for this type application".

I can see you have put a lot of thought into this and so it has been removed :+1:.

MatKallada commented 10 years ago

@Glavin001 I want to hear your opinions to add sense to this discussion. If you wanted to keep it, then voice your opinions. Hopefully, we can move on to be more open to get opinions from myself and others in the community; not just unstructured votes. Please also remember that this is a community project.

you have put a lot of thought into this

I am debating the professional design of the application, which should always be given priority. Every small detail matters; I have an infinite amount of time to create an amazing product from every angle.

Anyway, I get the feeling that these opinions will probably not be shared. Thanks for your time :+1:

Glavin001 commented 10 years ago

I am debating the professional design of the application, which should always be given priority. Every small detail matters; I have an infinite amount of time to create an amazing product from every angle.

Absolutely agree, although my time is valuable and I do not have an infinite amount of time :wink:. That would be nice.

My opinion is that this footer does not diminish the professionalism of our application. The "Made with <3" was included from the original scaffolded project from the generator and my intention by leaving it was to add a little personality to the application.

Given that it was not perceived as intended -- positively, and showing personality and care for this application by it's maintainers -- by the target audience -- yourself -- my original gut feeling has been since proved invalid, and so it has now been removed.