mozilla / security-advisor-shield-study

Mozilla Public License 2.0
2 stars 7 forks source link

Cannot `jpm run` with Firefox 48 #43

Closed Osmose closed 8 years ago

Osmose commented 8 years ago

I cannot test the add-on via jpm run on Firefox 48, branded or unbranded. Firefox launches with the following error:

JPM [info] Starting jpm run on Security Advisor
JPM [info] Creating a new profile
1472163387955   addons.xpi      WARN    Add-on @security-advisor is not correctly signed.
1472163387956   addons.xpi      WARN    Add-on @security-advisor is not correctly signed.
gregglind commented 8 years ago

I claim unbranded 48 should work.

npm install -g get-firefox
get-firefox -cb unbranded-release
mythmon commented 8 years ago

This is also working for me, using this unbranded build, which came from https://wiki.mozilla.org/Add-ons/Extension_Signing

mythmon commented 8 years ago

Closing since we can't seem to reproduce.

Osmose commented 8 years ago

Weird, Benton was able to reproduce the issue as well when I first noticed it.

Osmose commented 7 years ago

I have since discovered that my unbranded copy of Firefox was replaced by a branded copy of Firefox, potentially due to this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1290548

Either way, I re-downloaded a new unbranded copy and things worked fine. Sorry for the confusion!

Christos-Papoulas commented 7 years ago

I have the same problem with Firefox 49.0.1, before the update everything worked fine. How can overcome this issue?

row2x commented 7 years ago

I am having the same problem in Firefox 49.0.1, and previous add-on worked fine. Any ideas will be appreciated.

mythmon commented 7 years ago

@Christos-Papoulas @sentryone: Since upgrades from unbranded versions of Firefox 48 to 49 for a while was converting them to branded versions, can you try and download a fresh, unbranded version of Firefox from here and trying again?

row2x commented 7 years ago

Actually just got a tip from someone and if I downloaded Firefox Nightly it worked:

jpm run -b Nightly

Thank you for your input!

mohammadlachgar commented 7 years ago

Thank "mythmon"

jpm -b "C:\Program Files (x86)\Mozilla Developer Preview\firefox.exe" run