search

mozilla / security-advisor-shield-study

Mozilla Public License 2.0
2 stars 7 forks source link

Add-on seems to break if I disable then re-enable via about:addons #51

Closed pdehaan closed 7 years ago

pdehaan commented 7 years ago

Found in b6f5565 (via git rev-parse --short HEAD).

Steps to reproduce:

  1. Git clone repo.
  2. $ npm install
  3. $ npm run build
  4. $ jpm run -b Aurora (or if you don't have a global JPM installed, try $ ./node_modules/.bin/jpm run -b Aurora).
  5. Go to http://www.adobe.com and verify the alert appears in address bar.
  6. Go to about:addons and select Security Advisor.
  7. Press Disable to disable add-on.
  8. Press Enable to re-enable add-on.
  9. Look at your Terminal window.
  10. Go to http://www.adobe.com and verify the alert still reappears after re-enabling.

    Actual results:

$ ./node_modules/.bin/jpm run -b Aurora
JPM [info] Starting jpm run on Security Advisor
JPM [info] Creating a new profile

1475710024402   addons.xpi      ERROR   Attempted to load bootstrap scope from missing directory /var/folders/qc/g_f0szh95k1fzph34rhmf5jw0000gp/T/06bf11d1-4b5b-4c24-ac98-f5af52e5021f/extensions/@security-advisor.xpi
1475710024402   addons.xpi      WARN    Add-on @security-advisor is missing bootstrap method startup
1475710024406   addons.xpi      WARN    No XPIState for @security-advisor in app-profile

The add-on seems to not work after re-enabling it.

Before:

about_config

After:

about_config

pdehaan commented 7 years ago

Not sure if this is because I'm running via jpm run -b Aurora versus another method and disabling and reenabling changes some temp folder.

pdehaan commented 7 years ago

index_of_jar_file____var_folders_qc_g_f0szh95k1fzph34rhmf5jw0000gp_t_c43465fa-9586-4ac4-bb41-a0ef7886a745_extensions__security-advisor_xpi__

Osmose commented 7 years ago

Thanks for the report!

I'm unable to get past Step 8, as once I click disable, the add-on is automatically uninstalled, which is expected behavior. I'm testing on the latest Dev Edition on OSX.

@pdehaan Can you confirm that the add-on does not disappear from the add-on list when you disable it?

gregglind commented 7 years ago

(Echoing that it SHOULD be that disable uninstalls. Odd!)

On Thu, Oct 6, 2016 at 3:36 PM, Michael Kelly notifications@github.com wrote:

Thanks for the report!

I'm unable to get past Step 8, as once I click disable, the add-on is automatically uninstalled, which is expected behavior. I'm testing on the latest Dev Edition on OSX.

@pdehaan https://github.com/pdehaan Can you confirm that the add-on does not disappear from the add-on list when you disable it?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mozilla/security-advisor-shield-study/issues/51#issuecomment-252107959, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKAj1f2tK9FGVWMgFHhgUD1JJth8gmDks5qxXfjgaJpZM4KPZmA .

pdehaan commented 7 years ago

Actually now it seems to uninstall the add-on when I disable the add-on in about:addons. Although it also opens a new tab: https://www.mozilla.org/en-US/?fxVersion=51.0a2&reason=user-ended-study&updateChannel=aurora&variation=auto-open-panel&who=unknown&xname=Security+Advisor+Test

blank_skitch_document

UPDATE: Same behavior (uninstall on disable) when using latest Nightly as well:

blank_skitch_document