mozilla / security-advisor-shield-study

Mozilla Public License 2.0
2 stars 7 forks source link

Long site names cause text to underflow in the popup #56

Open pdehaan opened 7 years ago

pdehaan commented 7 years ago

Found in a12637c7489855bda5a5946999566f2dd47faf09 (via git rev-parse HEAD --short).

Steps to reproduce:

  1. Install add-on ($ ./node_modules/.bin/jpm run -b Aurora) and go to www.androidforums.com.
  2. Note that the popup says "Android Forums was compromised in 2011, ...".

    Actual results:

The "Why am I seeing this?" text is underflowing the buttons at the bottom of the popup due to line wrapping and long site names.

menubar_and_android_forums_and_custom_formats_-_asynchronous_validation_ _issue__40_ _epoberezkin_ajv

pdehaan commented 7 years ago

Oh, and I forgot to post this earlier, but it looks like the longest title is "Telecom Regulatory Authority of India":

const localData = require('./data/recommendation/localData.json');

const longest = localData.reduce((curr, prev) => {
  return (curr.Title.length > prev.Title.length) ? curr : prev;
}, localData[0]);

console.log(JSON.stringify(longest, null, 2));

{ Title: 'Telecom Regulatory Authority of India',
  Name: 'TRAI',
  Domain: 'trai.gov.in',
  BreachDate: '2015-04-27',
  AddedDate: '2015-04-27T11:21:59Z',
  PwnCount: 107776,
  Description: 'In April 2015, the Telecom Regulatory Authority of India (TRAI) <a href="http://www.dnaindia.com/scitech/report-email-savetheinternet-net-neutrality-campaign-public-privacy-spam-phishing-2081037" target="_blank">published tens of thousand of emails</a> sent by Indian citizens supporting net neutrality as part of the SaveTheInternet campaign. The published data included lists of emails including the sender\'s name and email address as well as the contents of the email as well, often with signatures including other personal data.',
  DataClasses: [ 'Email addresses', 'Email messages' ],
  IsVerified: true,
  IsSensitive: false,
  IsActive: true,
  IsRetired: false,
  LogoType: 'svg' }