First attempt at sample multiplier.

mozilla / self-repair-server

This project is now EOL, replaced by Normandy Recipe Server.

6 stars 11 forks source link

Closed ghost closed 8 years ago

ghost commented 9 years ago

First iteration. Please review whether this is the correct strategy.

If it is we need to address the following...

Things that you might want to double check:

118 - should we be storing something other than datestrings? We could make this millis but it would be less readable.
152 - Is there a more effectient way to get millis here?
156 - Should multiplier be bounded? i.e. [1.0, 1000.0]

TODOs:

ghost commented 9 years ago

Just noticed that I'm missing some semicolons on the helper variable declarations, will fix

gregglind commented 9 years ago

RE: #160

ghost commented 9 years ago

Updated, still need test coverage.

I'd appreciate general feedback as well as double checking that the variable/function names are adequate.