Wrong direct link when share in facebook

mozilla / send

Simple, private file sharing from the makers of Firefox

https://send.firefox.com

Mozilla Public License 2.0

13.24k stars 1.55k forks source link

Wrong direct link when share in facebook #1354

Open tranlehaiquan opened 5 years ago

tranlehaiquan commented 5 years ago

I have a send link with password. When I shared it through Facebook messenger (on website) it will redirect to another link not which i want.

My file: https://send.firefox.com/download/fb01d0252e05f07b/#IT3oR8BAx5nkI5IvrweCew Facebook will direct to: https://send.firefox.com/download/fb01d0252e05f07b/?fbclid=IwAR3UM1S96aw8_8WQfTgHdqkQi9nmOFrua9xz6RZB0Jdmcea6yjKTE9O7v54#IT3oR8BAx5nkI5IvrweCew

geekykant commented 5 years ago

I would agree more to it for Facebook to solve this query string problem. The unique tracking parameter added by Facebook, just fails itself to redirect properly.

tranlehaiquan commented 5 years ago

But i don't know if it is right or wrong. It redirect me to same page with password. I lost 30 minutes to figure that out : )).

clouserw commented 5 years ago

It looks like this is something facebook adds for tracking. It does break the download link though so it's a legitimate bug -- we should strip out or ignore any extra URL params