search

mozilla / send

Simple, private file sharing from the makers of Firefox
https://send.firefox.com
Mozilla Public License 2.0
13.27k stars 1.58k forks source link

Fenix doesn't work with Send #1404

Open NotWoods opened 5 years ago

NotWoods commented 5 years ago

Originally filed as mozilla-mobile/fenix#3336.

Steps to reproduce

  1. upload a file to send.firefox.com
  2. copy the download URL
  3. open the download URL
  4. press the "Download" button
  5. confirm that you want to download the file

Expected behavior

Fenix downloads the file properly.

Actual behavior

Fenix downloads a file with the correct name, but the file is a short text file containing Unauthorized.

Firefox Preview currently performs downloads in two steps. Gecko find out about the download, then our Android Components library fetches the resource. This behaviour doesn't work properly with Send.

This issue has previously been investigated, and currently Send whitelists Firefox Preview in the Service Worker and treats it similar to Safari. However the issue is still occuring in Firefox Preview.

I'd recommend the team try using the Android emulator and install the latest APK from Fenix releases to see this happen. I can help with setting up the emulator.

cpeterso commented 5 years ago

Agi says he can reproduce this bug in Fenix, but it works in Fennec 68. So this is either a regression in Gecko 69 or 70 or Send is doing something different for Gecko >= 69

https://bugzilla.mozilla.org/show_bug.cgi?id=1572813

NotWoods commented 5 years ago

Send started doing something different for Gecko >= 69 to try and fix the issue (the whitelist mentioned in the bug). Previously the code was the same, as far as I know. It's probably a regression.

googlebleh commented 4 years ago

Reproduced the same problem in Chrome on a Pixel 2, and on a Samsung Galaxy.

Worked around the issue by changing settings to request desktop site.