search

mozilla / servicebook-web

Web Frontend for the service book
Other
4 stars 10 forks source link

Fix docker-[build|run|attach Makefile targets #138

Closed stephendonner closed 6 years ago

stephendonner commented 6 years ago

Fixes Issue #137

@tarekziade @ckolos @davehunt r?

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 84.859% when pulling 882cbbe8656330f6f98cbe5e708d345a35fe32b0 on stephendonner:issue-137 into f646a0130d1fc4c217d62cb55fce8db5768a1305 on mozilla:master.

stephendonner commented 6 years ago

It would be less work, yes; I started down that route, but then noticed how servicebook had it, and went for consistency with that (since it seems to get more action) repo.

https://github.com/mozilla/servicebook/tree/b1cf1d8d450315c314120b295310110a78af32aa#running-with-docker https://github.com/mozilla/servicebook/blob/b1cf1d8d450315c314120b295310110a78af32aa/Makefile#L29-L33

But, I can be swayed/cajoled.