search

mozilla / servicebook-web

Web Frontend for the service book
Other
4 stars 10 forks source link

Introduce pipenv for consistent environments #167

Closed davehunt closed 6 years ago

davehunt commented 6 years ago

This patch introduces pipenv for consistent environments, and also updates the Docker image to use pipenv. This means that local development should be identical to deployment using the Docker images built by Circle CI. This also fixes an issue that's occuring in Circle CI where the server is responding with status code 500. Unfortunately this is currently considered acceptable as we only check that we get a response, and not the value of the status code.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 82.599% when pulling e82bca3d7062742ec9dc38a5c1569f619cfb8845 on davehunt:pipenv into b184d8343acac128bd091321895b0ee8d0b31f48 on mozilla:master.

davehunt commented 6 years ago

Closing/re-opening to hopefully trigger Circle CI build

stephendonner commented 6 years ago

Thanks, @davehunt - this should take care of https://github.com/mozilla/servicebook-web/issues/139