mozilla / servicebook-web

Web Frontend for the service book
Other
4 stars 10 forks source link

Fix path to static font files #192

Closed davehunt closed 6 years ago

davehunt commented 6 years ago

_FONTS was including the directory name serviceweb, which meant the font files could not be found. Fixes #191

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 84.956% when pulling 7f9963861b6df3b3c72c42692dd5c55994616707 on davehunt:issue191 into 2adb4fb766241ca398b6e9b1bd2f797e3c499b85 on mozilla:master.

tarekziade commented 6 years ago

Notice that the static files are served directly via NGINX in the deployment. This is a dev fallback

davehunt commented 6 years ago

Notice that the static files are served directly via NGINX in the deployment. This is a dev fallback

Hmm.. so is there another issue that's causing the glyphs to fail on https://servicebook.stage.mozaws.net/?

tarekziade commented 6 years ago

I suspect so. We should look at where Nginx looks for them and fail cc @ckolos

ckolos commented 6 years ago

I see this in the error logs:

/data/servicbook/fonts/glyphicons-halflings-regular.ttf: No such file or directory

But I suspect a missing an 'e' in there somewhere b/c /data/servicebook/fonts/glyphicons-halflings-regular.ttf is definitely there ;)

[root@ip-172-31-46-103 static]# ls -lrt /data/servicebook/fonts/glyphicons-halflings-regular.ttf                                                                            
-rw-r--r-- 1 root root 45404 Sep 18 18:12 /data/servicebook/fonts/glyphicons-halflings-regular.ttf
davehunt commented 6 years ago

@ckolos there are several requests for fonts, an example that's returning 404 is https://servicebook.stage.mozaws.net/fonts/glyphicons-halflings-regular.ttf

davehunt commented 6 years ago

Is this an nginx configuration issue?

ckolos commented 6 years ago

yes; that's where the 'e' was missing

davehunt commented 6 years ago

@ckolos I'm confused, is this something you've fixed? It does appear to be working now.

ckolos commented 6 years ago

Yes. I fixed it and pending a PR landing in our deployment code, it will not happen again.