search

mozilla / servicebook

A web service to manage our projects
Mozilla Public License 2.0
15 stars 6 forks source link

Update Pipfile.lock #132

Closed stephendonner closed 6 years ago

stephendonner commented 6 years ago

This fixes the lockfile, I've confirmed, but not the build; I'm not after upgrading individual dependencies , except:

pyyaml < 3.13 is listed as vulnerable, so we might want to update that soon, though!

@davehunt r? I promise to not spend more time on this right now :-)

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at ?% when pulling 920edc74b21df4292d6d9946773a2dea668c5823 on stephendonner:fix-Pipfile-dot-lock into 9c6569c19bbc23f486d8ded94382ec15c5bfbfcd on mozilla:master.

stephendonner commented 6 years ago

i.e. if we take this, we can also 1) close + delete https://github.com/mozilla/servicebook/pull/128 and then 2) wait for a new PR from pyup.io for pyyaml 3.13.

davehunt commented 6 years ago

I'm uncertain of the consequences of merging this. There are lots of new dependencies here, and Travis CI doesn't like it. I'd like to dedicate some time to updating Service Book but first I'd like some insight into the deployment process from @tarekziade and @ckolos. I'm at a conference this week (where I may even learn some things that could help us here), and then after a few days I'm on PTO for a week. If it can, I'd like to ask for this to wait for my return. If someone else has time to take this before then, I'll learn what I can from their work.