search

mozilla / servicebook

A web service to manage our projects
Mozilla Public License 2.0
15 stars 6 forks source link

Attempt to migrate to Circle CI v2.0 #139

Closed davehunt closed 6 years ago

davehunt commented 6 years ago

I saw @ckolos had a branch in progress, however it appears to be out of date. I'm not entirely clear on how we deploy Servicebook from Docker Hub, but I think this configuration would replicate the existing workflow.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 92.226% when pulling 5d23851610d2a6dc514ac912ab54d6f892e6a800 on davehunt:circleci2 into 9c6569c19bbc23f486d8ded94382ec15c5bfbfcd on mozilla:master.

ckolos commented 6 years ago

If yours is actually working, then that wfm. For some reason, my branch is failing the test image job, though I'm not sure why.

davehunt commented 6 years ago

Ah, I see the curl command is done differently. That explains that.

Yes, the job and remote docker run in separate evironments, so they can't see each other. See https://circleci.com/docs/2.0/building-docker-images/#separation-of-environments.

ckolos commented 6 years ago

+1

davehunt commented 6 years ago

@ckolos same issue here with "Error: Cannot perform an interactive login from a non TTY device".

ckolos commented 6 years ago

Confirmed the fixes applied allowed a new container to be pushed to dockerhub