search

mozilla / shield-studies-addon-template

DEPRECATED. Please use https://github.com/mozilla/normandy-nextgen-study-example instead (Old description: Example Firefox Add-on Shield Study built as a Web Extension with Web Extension Experiments to run privileged code where necessary)
https://github.com/mozilla/normandy-nextgen-study-example
Mozilla Public License 2.0
8 stars 22 forks source link

run-firefox enh: screenshots, pings, more #24

Open gregglind opened 6 years ago

gregglind commented 6 years ago

Should run-firefox take screenshots? How often? Store them where?
Telemetry... should it print all shield-study, shield-study-addon telemetry? how to catch those?

Maybe it should screenshot every time there is a telemetry ping

gregglind commented 6 years ago

THe screenshotting api i want looks more like this:

Then I can do test runs that take screenshots at all the right times.

gregglind commented 6 years ago

Listening for a custom event from selenium-webdriver

https://stackoverflow.com/questions/35884230/can-my-webdriver-script-catch-a-event-from-the-webpage

gregglind commented 6 years ago

Conclusion: trying to signal FROM THE ADDON that 'you should take a screenshot' seems... weird and not right.

I think it's better to make that an explicit part of the script run. OR if you are running manual, it is on you to take screenshots.

motin commented 5 years ago

"print all shield-study, shield-study-addon telemetry" is covered by https://github.com/mozilla/shield-studies-addon-template/pull/98/commits/30131749c6d23385e35083e8693dec15fbbefac1