search

mozilla / shield-studies-addon-utils

Mozilla Public License 2.0
6 stars 21 forks source link

integrate ending changes into utils #267

Closed gregglind closed 4 years ago

gregglind commented 6 years ago

https://searchfox.org/mozilla-central/source/toolkit/components/normandy/test/unit/test_addon_unenroll.js

41-52: Rename 'onStudyEnded' to 'onNormandyStudyEnded' needs consistent with 66. 66-74: Use as is, after rename. This is the standard event firing pattern. 82-90: The actual work. Listen for onNormandyStudyEnded.

Future: @mythmon adds the 'reason' or 'options' flag for the reason (about:studies, vs normandy pull-back). This will affect:

71: () => fire.sync() becomes (stuff) => fire.sync(stuff) 83: becomes: browser.study.onStudyEnded.addListener((stuff) => { // and then react to stuff.

mythmon commented 5 years ago

Future: @mythmon adds the 'reason' or 'options' flag for the reason (about:studies, vs normandy pull-back).

This has been done in bug 1488923. It is landing in Nightly 64, and should be uplifted to Beta 63.