search

mozilla / shielddash

Dashboard for SHIELD study reports.
http://shielddash.herokuapp.com/
Mozilla Public License 2.0
2 stars 5 forks source link

Add auth to study details view. #20

Closed jezdez closed 8 years ago

jezdez commented 8 years ago

And some other minor things.

jezdez commented 8 years ago

@robhudson r?

robhudson commented 8 years ago

That was fast. This looks great.

If you haven't already, can you review the tests? This was obviously missing a check in the tests that this endpoint required auth (or the test provided the auth but the view never used it).

jezdez commented 8 years ago

@robhudson Yep, added a test for the auth stuff, at least via the session backend. The JWT backend is untested at the moment.

robhudson commented 8 years ago

Great changes. r+