search

mozilla / shumway

Shumway is a Flash VM and runtime written in JavaScript
Apache License 2.0
3.68k stars 397 forks source link

Implement ID3v2 tag parsing for the ID3 Class #74

Open mbebenita opened 11 years ago

mbebenita commented 11 years ago

After audio data is loaded we need to parse and populate the id3 property of the Audio class.

jimporter commented 10 years ago

We could probably use the Firefox OS ID3 parser for this: https://github.com/mozilla-b2g/gaia/blob/master/apps/music/js/metadata.js

I have a pull request up for the FxOS ID3 parser that vastly improves it. We could either copy the code over or make a separate library that both this and FxOS use.

tschneidereit commented 10 years ago

Ah, nice. Can you post here again once the changes are merged? I'm sure @yurydelendik will be interested :)

jimporter commented 10 years ago

It's taken ages, but I expect my changes to the FxOS parser will be merged on March 17 (when FxOS 1.5 development starts up). After that lands, I'll try to split it off into its own library that can be shared by FxOS and Shumway.

tschneidereit commented 10 years ago

Awesome, this'll be great to have!

jimporter commented 9 years ago

Are there any stubs for Shumway's ID3 parsing yet? (And ideally, some pointers to documentation about how the ID3 tag should be emitted.) Firefox OS's ID3 parser is probably in good enough shape that it can be ported over to Shumway now.