The Side View pop up is blank for a brief moment when the toolbar button is clicked multiple times, after sending links from the "nytimes.com" website to the sidebar

Softvision-CristinaBadescu commented 6 years ago

[Notes]:

On Mac, this issue is easier to be encountered if you send a link from "nytimes.com" page to the sidebar, click quickly the toolbar button multiple times and then send another link and click the toolbar button again.
I've encountered this issue only for the links sent from the "nytimes.com" website, but there could be more websites like this that can cause this behavior.

[Affected versions]:

Nightly 62.0a1
Side View 0.4.3

[Affected Platforms]:

All Windows
All Mac
All Linux

[Prerequisites]:

Have a clean Firefox profile with the latest Side View version 0.4.3 installed.

[Steps to reproduce]:

Open the Firefox browser with the profile from prerequisites.
Navigate to "https://www.nytimes.com".
Right click an article title and select the "Open link in sidebar" option.
Rapidly click the toolbar button multiple times.
Repeat Steps 3 & 4 with different articles and observe the behavior.

[Expected result]:

Each time the Side View pop up is correctly opened and closed.

[Actual result]:

The Side View pop up is blank for a brief moment and afterwards it is populated.

[Regression]: I've managed to find a regression-windows using the Mozregression tool. Here are the results: Last good revision: 8d070df4285e4eb45015ad5023bb220088d62af5 First bad revision: ad3d005f6a3683d095095fcb22dc875b07318a2b Pushlog: https://goo.gl/25P2kN

From the pushlog, it seems that bug 1414245 has caused this issue.

[Additional notes]:

I've filed a Bugzilla issue here: bug 1461988.
Sometimes, the "Current" and "Recent Tabs" appear for a brief moment, but they are not populated.
This issue is easy to be noticed if Dark Theme is enabled.
Here is a screen screen recording with this issue:

Softvision-CristinaBadescu commented 6 years ago

For this issue, Shane made a suggestion: https://bugzilla.mozilla.org/show_bug.cgi?id=1461988#c9.

ddurst commented 6 years ago

I've closed the BMO version of this (from the WebExtensions: Frontend POV).

Note that the REO has flagged this as fix-optional for 62. (Guess we should have labels like that? Dunno.)

mozilla / side-view

The Side View pop up is blank for a brief moment when the toolbar button is clicked multiple times, after sending links from the "nytimes.com" website to the sidebar #254