search

mozilla / side-view

An experiment with opening mobile views of pages in the sidebar
Mozilla Public License 2.0
190 stars 41 forks source link

Clicking the “Watch a tutorial” link in the “Welcome” screen will open two tabs with the tutorial on YouTube #464

Open acornestean opened 3 months ago

acornestean commented 3 months ago

[Affected versions]: Firefox Release 129.0.2 Firefox Beta 130.0 Firefox Nightly 131.0a1

[Affected Platforms]: Windows, MacOS, Linux

[Steps to reproduce]:

  1. Install Side View version 0.6.5727 (based on the current master branch https://github.com/mozilla/side-view/releases/tag/0.5rc7) via about:debbugging OR via “Install Add-on From File” in Add-ons Manager (after setting xpinstall.signatures.required to false in about:config)
  2. Have the "Welcome" screen open in the sidebar
  3. Click on the “Watch a tutorial” link

[Expected result]: The tutorial on YouTube should open in a new tab

[Actual result]: Two tabs with the tutorial on YouTube are opened

jaredhirsch commented 3 months ago

@acornestean Thanks for filing. Could you share an example youtube URL that triggers this bug?

acornestean commented 3 months ago

I refined the STR a bit and attached a screen recording of the issue for more clarity.

STR:

  1. Install Side View version 0.6.5727
  2. As the sidebar no longer opens automatically on extension installation, manually open the sidebar via CTRL+B. This will open the sidebar on “Bookmarks”
  3. From the dropdown menu at the top of the sidebar, select “Side View”
  4. Notice the “Welcome” screen is displayed in the sidebar, which has a “Watch a tutorial” link
  5. Click the “Watch a tutorial” link
  6. Observe that two new tabs will be opened with the tutorial on YouTube

https://github.com/user-attachments/assets/a6b572ae-04c8-4811-8213-b44b29ef7349