search

mozilla / source

DEPRECATED - Code for source.mozillaopennews.org/
https://source.opennews.org
BSD 3-Clause "New" or "Revised" License
36 stars 27 forks source link

Code block display bug at top of article #189

Closed kissane closed 11 years ago

kissane commented 11 years ago

I'm fine-tuning production on Kio's latest case study (http://source.mozillaopennews.org/admin/articles/article/112/) and it looks like the code block in the very first section is overlapping the sidebar with the outline and pub date and so on. Screenshot in Chrome/Mac attached.

screen shot 2013-05-08 at 5 33 54 pm

Short notice, but any help is appreciated!

ryanpitts commented 11 years ago

I dropped a fix inline for just that article, adding a style="display: inline-block" to the pre element.

Those are all block-level elements sitting next to the floated aside there, so even though the text wraps fine, anything with background color would display that way. Not sure there's a particularly elegant solution that would handle this automatically. We could apply inline-block to all our pre elements, but then ones further down the page would only be as wide as their text, which I'm not sure is a better solution.

Any thoughts?

kissane commented 11 years ago

Great, thanks! This is actually quite a rare occurrence, so I'm fine with an inline tweak. Much obliged!

On Wed, May 8, 2013 at 6:08 PM, Ryan Pitts notifications@github.com wrote:

I dropped a fix inline for just that article, adding a style="display: inline-block" to the pre element.

Those are all block-level elements sitting next to the floated asidethere, so even though the text wraps fine, anything with background color would display that way. Not sure there's a particularly elegant solution that would handle this automatically. We could apply inline-block to all our pre elements, but then ones further down the page would only be as wide as their text, which I'm not sure is a better solution.

Any thoughts?

— Reply to this email directly or view it on GitHubhttps://github.com/mozilla/source/issues/189#issuecomment-17637200 .