search

mozilla / source

DEPRECATED - Code for source.mozillaopennews.org/
https://source.opennews.org
BSD 3-Clause "New" or "Revised" License
36 stars 27 forks source link

CSS bug #201

Closed kissane closed 11 years ago

kissane commented 11 years ago

I'm seeing some CSS weirdness with this unpublished piece: http://source.mozillaopennews.org/en-US/learning/design-principles-news-apps-graphics/

screen shot 2013-05-29 at 1 10 22 pm

Maybe related to last week's CSS tweaks?

ryanpitts commented 11 years ago

So last week's CSS tweaks didn't go quite far enough to catch this particular case, where the aside is long enough to stretch past not just one article-block, but two.

That fix switched from a crappy overflow: hidden solution, which was causing article-blocks to drop below the aside if the intro text was short, to a more proper "clearfix" approach. Which works great until you run into a really long aside with a short intro and a short first article-block. Clearfixing sets float: none immediately after the element, which means the second article-block still gets dropped below the aside.

Dropping the float: none after article-blocks fixes the problem on this page, but I'll need to check to be sure it doesn't break anything on other pages.

kissane commented 11 years ago

Thank you! And sorry about the dupe bug. My browser wigged out and when I reloaded it seemed not to have submitted.

On Wed, May 29, 2013 at 3:18 PM, Ryan Pitts notifications@github.comwrote:

So last week's CSS tweaks didn't go quite far enough to catch this particular case, where the aside is long enough to stretch past not just one article-block, but two.

That fix switched from a crappy overflow: hidden solution, which was causing article-blocks to drop below the aside if the intro text was short, to a more proper "clearfix" approach. Which works great until you run into a really long aside with a short intro and a short first article-block. Clearfixing sets float: none immediately after the element, which means the second article-block still gets dropped below the aside.

Dropping the float: none after article-blocks fixes the problem on this page, but I'll need to check to be sure it doesn't break anything on other pages.

— Reply to this email directly or view it on GitHubhttps://github.com/mozilla/source/issues/201#issuecomment-18639616 .

ryanpitts commented 11 years ago

Fix is on dev, visible in this article: https://source-dev.mozillalabs.com/en-US/articles/newsdev-roundup-august-22/

If you have a chance to put eyes on this, and maybe poke around on some other page types to make sure the fix didn't have any unintended consequences, that would be slick. I've checked around myself and everything seems to be OK, but always good to have a second set of eyes on things.

kissane commented 11 years ago

Looks good to me, checked against 7-8 articles in Features and Learning.

On Wed, May 29, 2013 at 3:50 PM, Ryan Pitts notifications@github.comwrote:

Fix is on dev, visible in this article: https://source-dev.mozillalabs.com/en-US/articles/newsdev-roundup-august-22/

If you have a chance to put eyes on this, and maybe poke around on some other page types to make sure the fix didn't have any unintended consequences, that would be slick. I've checked around myself and everything seems to be OK, but always good to have a second set of eyes on things.

— Reply to this email directly or view it on GitHubhttps://github.com/mozilla/source/issues/201#issuecomment-18641530 .

ryanpitts commented 11 years ago

Things like the Features and Learning cover, and the Code and Person indexes, those look OK too?

kissane commented 11 years ago

Yup, and also the People and Org profiles, Code entries, and static pages.

On Wed, May 29, 2013 at 4:37 PM, Ryan Pitts notifications@github.comwrote:

Things like the Features and Learning cover, and the Code and Person indexes, those look OK too?

— Reply to this email directly or view it on GitHubhttps://github.com/mozilla/source/issues/201#issuecomment-18644355 .

ryanpitts commented 11 years ago

Sweet.

OK, cover me, I'm going in.

kissane commented 11 years ago

On Wed, May 29, 2013 at 4:59 PM, Ryan Pitts notifications@github.comwrote:

Sweet.

OK, cover me, I'm going in.

— Reply to this email directly or view it on GitHubhttps://github.com/mozilla/source/issues/201#issuecomment-18645772 .

ryanpitts commented 11 years ago

OK, looks like we're good on prod: http://source.mozillaopennews.org/en-US/learning/design-principles-news-apps-graphics/

(May need to hard refresh to ensure that you get latest CSS update)

rossbruniges commented 11 years ago

@ryanpitts - I thought you were waiting for me to show up to do this, :beers: for getting in there and sorting stuff out.

That page is currently 404'ing but am guessing that's because I'm not logged into the admin.

Thanks!

ryanpitts commented 11 years ago

Ross! Yeah, I wasn't sure about your availability, so since this was just a CSS tweak, I went ahead and pushed it. I'm glad you showed me that site_update script last week!