search

mozilla / spidernode

Node.js on top of SpiderMonkey
https://ehsanakhgari.org/blog/2016-04-20/project-spidernode
Other
560 stars 42 forks source link

Implement v8::Name #13

Open ehsan opened 8 years ago

ehsan commented 8 years ago

This class is the base class of String and Symbol, and pretty small.

brendandahl commented 8 years ago

Seems this is implemented already?

ehsan commented 8 years ago

Seems this is implemented already?

Not that I know of! We have a partial String implementation, but nothing for Symbol yet.

This should be very easy! CheckCast can be dropped. Cast is trivial according to other Cast methods on the Value hierarchy. I don't have a great idea for GetIdentityHash() but fortunately Node doesn't use that function so we don't have to implement it. :-)

Would you like to give this a shot?